Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature upgrade three.js #397

Merged
merged 27 commits into from
Oct 26, 2024
Merged

Feature upgrade three.js #397

merged 27 commits into from
Oct 26, 2024

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented Oct 23, 2024 •
edited
Loading

List of improvements to jsartoolkitNFT:

  • solve issue emsdk 3.1.50 cause builds errors #363 and Fix for issue with isnan WebARKitLib#29
  • upgrade packages and three.js (r169) with updated examples too
  • new build and dist libs
  • updated github actions scripts
  • node version from 16.18.0 to 20.18.0
  • new gltf example
  • improves to makem.js:
    • removed --memory-init-file 0 flag because removed from newer emsdk version
    • restore correct functionality of NO_LIBAR option
    • avoid use of var, using let or const instead.
    • added const BUILD_BASE_FILENAME = "artoolkitNFT"; to simply name libs formations.

@kalwalt
fix for issue #363
dae41b5 
- emcc version > 3.1.40 cause issue with isnan
@kalwalt
upgraded emcc to 3.1.69
0c53dc3 
- build .o files instead of .bc
- related to issue #363
@kalwalt
updated node.js version to 20 and improved github actions
a7d5f28
@kalwalt kalwalt added bug Something isn't working enhancement New feature or request emscripten nodejs Three.js labels Oct 23, 2024
@kalwalt kalwalt self-assigned this Oct 23, 2024
@kalwalt
upgrade emsdk to 3.1.69 in the github action
fe6c861
@kalwalt
upgrading node packages and re-build of .ts libs
16f7ce1
@kalwalt
upgrading examples loading three.js with module import
b008e25
@kalwalt
upgrading basic and basic_embed_ES6 examples
799ccfd
@kalwalt
upgrading basic_threading and ARToolkitNFT_ES6_threading_example exam…
1ebbac6 
…ples
@kalwalt
gltf example with brave_robot model
bb6eb43 
- see issue #393
@kalwalt
multi example upgrade
fab5265 
- move marker position initialization from draw to onmessage (markerInfos)
- updating thread libs for the examples
@kalwalt
missed brave_robot model
2c24bb5
@kalwalt
use THREE.PerspectiveCamera instead of THREE.Camera
e6a1135 
- init the camera with a configuration (aspect, fov, near and far option)
@kalwalt
convert variables type var to let or const
0ac0413
@kalwalt
better makem.js file
524a510 
- Zlib is not necessary
- removed deprecated -memory-init-file flag
- correctly clean_builds
- improved code quality with better variable type
@kalwalt
useful commands for building libs with docker
e1379ef
@kalwalt kalwalt mentioned this pull request Oct 25, 2024
Closed
@kalwalt
Copy link
Member Author

kalwalt commented Oct 25, 2024

action build script fails with error:

 In file included from /src/emscripten/WebARKitLib/lib/SRC/ARUtil/file_utils.c:90:
/src/emscripten/WebARKitLib/lib/SRC/ARUtil/unzip.h:27:10: fatal error: 'zlib.h' file not found
   27 | #include "zlib.h"
      |          ^~~~~~~~
1 error generated.
emcc: error: '/emsdk/upstream/bin/clang -target wasm32-unknown-emscripten -fignore-exceptions -mllvm -combiner-global-alias-analysis=false -mllvm -enable-emscripten-sjlj -mllvm -disable-lsr --sysroot=/emsdk/upstream/emscripten/cache/sysroot -DEMSCRIPTEN -Werror=implicit-function-declaration -Xclang -iwithsysroot/include/fakesdl -Xclang -iwithsysroot/include/compat -I/src/emscripten/WebARKitLib/include -I/src/build/ -I/src/emscripten/ -I/src/emscripten/WebARKitLib/lib/SRC/KPM/FreakMatcher -Oz -D HAVE_NFT -D WITH_FILTERING=1 /src/emscripten/WebARKitLib/lib/SRC/ARUtil/file_utils.c -c -o /tmp/emscripten_temp_tsx7zski/file_utils_71.o' failed (returned 1)

exec error: 1
Built at Fri Oct 25 17:08:02 UTC 20[24](https://github.com/webarkit/jsartoolkitNFT/actions/runs/11522360757/job/32078339381#step:11:25)

i thought that zlib wasn't needed, maybe i hadn't did the test locally? i will check and in case if needed i will restore it.

@kalwalt
Copy link
Member Author

kalwalt commented Oct 25, 2024 •
edited
Loading

action build script fails with error:

 In file included from /src/emscripten/WebARKitLib/lib/SRC/ARUtil/file_utils.c:90:
/src/emscripten/WebARKitLib/lib/SRC/ARUtil/unzip.h:27:10: fatal error: 'zlib.h' file not found
   27 | #include "zlib.h"
      |          ^~~~~~~~
1 error generated.
emcc: error: '/emsdk/upstream/bin/clang -target wasm32-unknown-emscripten -fignore-exceptions -mllvm -combiner-global-alias-analysis=false -mllvm -enable-emscripten-sjlj -mllvm -disable-lsr --sysroot=/emsdk/upstream/emscripten/cache/sysroot -DEMSCRIPTEN -Werror=implicit-function-declaration -Xclang -iwithsysroot/include/fakesdl -Xclang -iwithsysroot/include/compat -I/src/emscripten/WebARKitLib/include -I/src/build/ -I/src/emscripten/ -I/src/emscripten/WebARKitLib/lib/SRC/KPM/FreakMatcher -Oz -D HAVE_NFT -D WITH_FILTERING=1 /src/emscripten/WebARKitLib/lib/SRC/ARUtil/file_utils.c -c -o /tmp/emscripten_temp_tsx7zski/file_utils_71.o' failed (returned 1)

exec error: 1
Built at Fri Oct 25 17:08:02 UTC 20[24](https://github.com/webarkit/jsartoolkitNFT/actions/runs/11522360757/job/32078339381#step:11:25)

i thought that zlib wasn't needed, maybe i hadn't did the test locally? i will check and in case if needed i will restore it.

Humbling a bit i didn't know if the unzip.h file is really needed or used, maybe i will can remove it in another release. i will open an issue for this.

@kalwalt kalwalt merged commit f0343ae into dev Oct 26, 2024
3 checks passed
kalwalt added a commit that referenced this pull request Oct 26, 2024
@kalwalt
Add USE_ZLIB flag to makem.js
62839a3 
- fix issue in comment #397 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kalwalt kalwalt

Labels
bug Something isn't working emscripten enhancement New feature or request nodejs Three.js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kalwalt